Add client options testing #562
Conversation
Signed-off-by: Nathan Smith <nathan@chainguard.dev>
Codecov Report
@@ Coverage Diff @@
## main #562 +/- ##
==========================================
+ Coverage 36.67% 39.03% +2.35%
==========================================
Files 19 19
Lines 1445 1445
==========================================
+ Hits 530 564 +34
+ Misses 855 819 -36
- Partials 60 62 +2
Continue to review full report at Codecov.
|
|
Okie, We can drop this if GRPC cut over is happening soon. I was just looking around the repo for easy test coverage to add honestly 😆 |
| @@ -0,0 +1,62 @@ | |||
| // | |||
| // Copyright 2021 The Sigstore Authors. | |||
There was a problem hiding this comment.
| // Copyright 2021 The Sigstore Authors. | |
| // Copyright 2022 The Sigstore Authors. |
There was a problem hiding this comment.
Ah right we should update the boilerplate everywhere and the boilerplate test to match...
There was a problem hiding this comment.
no, this is added when you create the file first time.
if is a new file you add the current year
Summary
Adds some tests for the
WithTimeoutandWithUserAgentoptions for the client. While this legacy client will be deprecated soon, these were some easy tests to write so why not? Not sure if we're keeping library API compat in the deprecation to GRPC, but if so perhaps these can be good tests to make sure we reimplement this when cutting over to the new client.Ticket Link
Release Note